refactor: rewrite model (MyModel and MyCRUD) #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- merge: MyModel and MyCRUD
- Tests: 56, Assertions: 7, Skipped: 49
- Tests: 56, Assertions: 13, Skipped: 45.
- Tests: 56, Assertions: 17, Skipped: 42
- Tests: 56, Assertions: 22, Skipped: 37
- Tests: 58, Assertions: 30, Skipped: 32
- add costume where `Query::whereBinds` - Tests: 59, Assertions: 33, Skipped: 30
- Tests: 60, Assertions: 34, Skipped: 30
- Tests: 67, Assertions: 66, Skipped: 11
SonyPradana
commented
Feb 27, 2024
| @@ -0,0 +1,26 @@ | |||
| <?php | |||
There was a problem hiding this comment.
ambigus with original Collection, try to changes ModelCollection or other.
- `Collection` upstream update and delete - add `Model::getPrimeryKey()`, `Model::isExist()`, `Model::findOrCreate` - change visibility `Model::$where` to be `protected` - 68 tests, 95 assertions
|
finishing... |
| /** | ||
| * @return CollectionImmutable<string, mixed> | ||
| */ | ||
| public function hasOne(string $table, string $ref = 'id') |
There was a problem hiding this comment.
how about return as model, and Model::class instead of table_nama
anggerpradana
requested changes
Mar 1, 2024
| /** | ||
| * @return CollectionImmutable<string|int, mixed> | ||
| */ | ||
| public function hasMany(string $table, string $ref = 'id') |
There was a problem hiding this comment.
how about return as model, and Model::class instead of table_name
| // private -------------------- | ||
|
|
||
| /** | ||
| * Get column change status (compare with fresh record). |
anggerpradana
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor model, combine MyModel and MYCRUD
MyCrud Capability
MyModel Capability