Implement Sorbet -> Prism translations for op assigns for local and instance variables #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
approved these changes
Sep 4, 2024
Comment on lines
+343
to
+351
| case PM_INSTANCE_VARIABLE_AND_WRITE_NODE: { | ||
| return translateAssignment<pm_instance_variable_and_write_node, parser::AndAsgn, parser::IVarLhs>(node); | ||
| } | ||
| case PM_INSTANCE_VARIABLE_OPERATOR_WRITE_NODE: { | ||
| return translateAssignment<pm_instance_variable_operator_write_node, parser::OpAsgn, parser::IVarLhs>(node); | ||
| } | ||
| case PM_INSTANCE_VARIABLE_OR_WRITE_NODE: { | ||
| return translateAssignment<pm_instance_variable_or_write_node, parser::OrAsgn, parser::IVarLhs>(node); | ||
| } |
There was a problem hiding this comment.
Yeah it's rare for C++ to make me go "ooooh ahhhhh" but that's what this code does 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111
Closes #112
Closes #113
Closes #126
Closes #127
Closes #128
Test plan
See included automated tests.