Fix flipper id change #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix latest flipper plugin not working
Description
The Flipper plugin ID was changed in #95, but the actual value returned by getId was not, resulting in the renamed plugin not working. I update to the correct ID defined here: https://github.com/Shopify/react-native-performance/blob/main/packages/flipper-plugin-react-native-performance/package.json#L4
Also, I remove the old plugin reference from the fixture so the issue is easier to catch (the new plugin version is already there)
Test plan
Checklist
I have added a decision record entry, PR includes changes to monorepo setup that may require explanation