fix: prevent calls to setState when disabled

Shopify · May 26, 2023 · 482b814 · 482b814
1 parent cd7d8f9
commit 482b814
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/packages/react-native-performance-navigation/src/ReactNavigationPerformanceView.tsx b/packages/react-native-performance-navigation/src/ReactNavigationPerformanceView.tsx
@@ -33,13 +33,13 @@ export const ReactNavigationPerformanceView = (props: Props) => {
   );
 
   useEffect(() => {
-    if (!isStack) {
+    if (!isStack || !stateController.isEnabled) {
       return;
     }
     return addListener('transitionEnd', () => {
       setTransitionEnded(true);
     });
-  }, [addListener, isStack]);
+  }, [addListener, isStack, stateController.isEnabled]);
 
   let shouldReportTransitionEnd = false;
   if (isStack && transitionEnded && transitionEndReported.current === false) {

diff --git a/...react-native-performance-navigation/src/__tests__/ReactNavigationPerformanceView.test.tsx b/...react-native-performance-navigation/src/__tests__/ReactNavigationPerformanceView.test.tsx
@@ -73,6 +73,9 @@ const createAddListenerMock = () => {
 describe('ReactNavigationPerformanceView', () => {
   beforeEach(() => {
     jest.clearAllMocks();
+    useStateControllerMock.mockReturnValue({
+      isEnabled: true,
+    });
   });
 
   describe('when screen is interactive on mount', () => {
@@ -276,4 +279,25 @@ describe('ReactNavigationPerformanceView', () => {
       });
     });
   });
+
+  describe('when disabled', () => {
+    beforeEach(() => {
+      useStateControllerMock.mockReturnValue({
+        isEnabled: false,
+      });
+    });
+
+    it('does not add a listener with setState for transitionEnd', () => {
+      const {wrapper, triggerTransitionEnd} = mountReactNavigationPerformanceView({
+        renderPassName: LOADING,
+        interactive: true,
+      });
+
+      wrapper.act(() => {
+        triggerTransitionEnd();
+      });
+
+      expect(wrapper.context.navigation.addListener).not.toBeCalledWith('transitionEnd', expect.anything());
+    });
+  });
 });