Fix crosshair position for a single data point in line chart #1726
+96
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
rita-morozova
requested review from
envex,
JeremyLudwigDev and
tylernoseworthy
envex
reviewed
Sep 19, 2024
| @@ -70,6 +70,15 @@ export function PointsAndCrosshair({ | |||
| } | |||
| const offset = isCrosshair ? selectedTheme.crossHair.width / 2 : 0; | |||
|
|
|||
| const allSingleDataPoints = data.every( | |||
There was a problem hiding this comment.
Do you think using .some instead so we're not always checking the entire data set would be better, or not worth the optimization?
const allSingleDataPoints = data.some(
(series) => series.data.length !== 1,
);
envex
approved these changes
Sep 19, 2024
rita-morozova
force-pushed
the
rita/fix-crosshair-offset
branch
from
dca0395
to
12a1bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When rendering a line chart with single data points per series, the crosshair was not aligned with the actual data points. This misalignment was caused by the animation logic. I am adding a condition to bypass the animation logic if all series have only one data point. Animating a single point or very sparse data does not provide any additional visual benefit to the user.
Does this close any currently open issues?
Related https://github.com/Shopify/core-issues/issues/71927
What do the changes look like?
Storybook link
Storybook
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package