Upgraded @headlessui/react to latest version (2.1.3) #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored many Component.Subcomponent (which are marked as deprecated by VSCode) to the separate/more direct imports (e.g. "Combobox.Input -> ComboboxInput) - Issue Link: Sendouc#1851
Screen.Recording.2024-09-01.at.11.52.36.movHmm otherwise I think looks good but this layout shift is a bit unfortunate. |
|
Very subtle change that you caught, thanks for double-checking Sendou! So I took a look at the @headlessui/react Repo and it is a confirmed issue with the version of the library itself. Someone else reported a bug that is very similar to this (very likely the same issue): tailwindlabs/headlessui#3396 So it's best to not proceed with the upgrade until they fix it in a later version. However, we can keep an eye on this linked Github issue at least =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link: #1851
Description of Changes
Upgraded @headlessui/react to latest version (2.1.3)
Component.Subcomponent(which are marked as deprecated by VSCode) to the separate/more direct imports (e.g.Combobox.Input->ComboboxInput)Tested the Combobox search feature in Build Analyzer and User Search & general navigation around the website, and I did not catch any functionality that broke.
===
Note: will require a rebuild & reupload of the bun lock file after merging other Pull Requests that contain dependency changes.