Add SLCC and kick out Basalt #1329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The imageproperties class is duplicating many things and actually makes the code harder to understand.
dirkmueller
reviewed
Jun 21, 2024
| @staticmethod | ||
| def build_tag_name_prefix(os_version: OsVersion) -> str: | ||
| """Prefix that is inserted in front of the name into the build tag""" | ||
| return "" if os_version.is_slcc else "bci-" |
There was a problem hiding this comment.
why are we removing the bci- prefix from slcc containers?
dirkmueller
reviewed
Jun 21, 2024
| @@ -54,7 +54,7 @@ | |||
| rpm -e compat-usrmerge-tools | |||
|
|
|||
| # FIXME: stop hardcoding the url, use some external mechanism once available | |||
| zypper -n ar --gpgcheck --enable 'https://updates.suse.com/SUSE/Products/ALP-Dolomite/1.0/$basearch/product/' repo-basalt | |||
| zypper -n ar --gpgcheck --enable 'https://updates.suse.com/SUSE/Products/ALP-Dolomite/1.0/$basearch/product/' repo-slci | |||
There was a problem hiding this comment.
Suggested change
| zypper -n ar --gpgcheck --enable 'https://updates.suse.com/SUSE/Products/ALP-Dolomite/1.0/$basearch/product/' repo-slci | |
| zypper -n ar --gpgcheck --enable 'https://updates.suse.com/SUSE/Products/ALP-Dolomite/1.0/$basearch/product/' repo-slcc |
|
I believe the bulk of this is already integrated. I'll cherry-pick the rest myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to cherry pick from #949