Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RailsEventStore and contribs dependency on RubyEventStore::ActiveRecord #1493

Closed
wants to merge 30 commits into from
Closed

RailsEventStore and contribs dependency on RubyEventStore::ActiveRecord #1493

wants to merge 30 commits into from

Commits on Jan 30, 2023

  1. Revert "Revert "PoC of double serialization prevention"" 

    This reverts commit 9b5081e.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    a46fb50 View commit details
    Browse the repository at this point in the history

  2. Revert "Revert "Pick correct serializer when testing"" 

    This reverts commit bda28e0.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7a34980 View commit details
    Browse the repository at this point in the history

  3. Revert "Revert "Less is more"" 

    This reverts commit fcaa701.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    809c852 View commit details
    Browse the repository at this point in the history

  4. Revert "Revert "Requirements for different column types"" 

    This reverts commit db1b197.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9394462 View commit details
    Browse the repository at this point in the history

  5. Revert "Revert "We don't introduce anything new over Value here"" 

    This reverts commit 101540d.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0052030 View commit details
    Browse the repository at this point in the history

  6. Revert "Revert "Big 🧠 time"" 

    This reverts commit ccc697e.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    55edd0a View commit details
    Browse the repository at this point in the history

  7. Revert "Revert "Boom, get proposed type for column from AR and act"" 

    This reverts commit c8310c8.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9c46da0 View commit details
    Browse the repository at this point in the history

  8. Revert "Revert "Extract to variable"" 

    This reverts commit 4d1508f.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    11bb5b0 View commit details
    Browse the repository at this point in the history

  9. Revert "Revert "More meaningful naming"" 

    This reverts commit b599d6a.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    39db759 View commit details
    Browse the repository at this point in the history

  10. Revert "Revert "No idea how to achieve the same in Rails < 6.1"" 

    This reverts commit b5a4e30.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    47eb2f6 View commit details
    Browse the repository at this point in the history

  11. Revert "Revert "Better describing what this test is for"" 

    This reverts commit 83ca36d.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9c71662 View commit details
    Browse the repository at this point in the history

  12. Revert "Revert "Document how to use json in RES 3.0"" 

    This reverts commit 310bdf8.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    3b60ebe View commit details
    Browse the repository at this point in the history

  13. No more aggregate root configuration 

    Since we have introduced AggregateRoot::Repository it is
easy to pass event store as a dependency there. No need
to use AggregateRoot::Configuration and default_event_store.

Make it explicte which event store is used. Less "magic".
    @mpraglowski @mostlyobvious
    mpraglowski authored and mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f0911b6 View commit details
    Browse the repository at this point in the history

  14. No longer exists

    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    1daa301 View commit details
    Browse the repository at this point in the history

  15. Remove deprecated JSONMapper

    @mpraglowski @mostlyobvious
    mpraglowski authored and mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    ae86bae View commit details
    Browse the repository at this point in the history

  16. No more aliases on RubyEventStore consts

    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f4d75da View commit details
    Browse the repository at this point in the history

  17. Get rid of dubious meta-apply method handlers 

    * no sane way to support event type scheme for extract last part
* no sane way to normalize every event type to method name
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0ca4767 View commit details
    Browse the repository at this point in the history

  18. Poor way to ensure with_strategy(->{ Default }) has OnDSL

    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    e3c7ac1 View commit details
    Browse the repository at this point in the history

  19. Refactor

    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f6f08bc View commit details
    Browse the repository at this point in the history

  20. Kill mutants

    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    097da18 View commit details
    Browse the repository at this point in the history

  21. EventClassRemapping superseded by upcasting

    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f69197b View commit details
    Browse the repository at this point in the history

  22. Revert "Revert "Raise ArgumentError when trying to publish nil as eve… 

    …nt""

This reverts commit 95d9bc9.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    05672ef View commit details
    Browse the repository at this point in the history

  23. Revert "Revert "Extract assertion to separate method and call it asap"" 

    This reverts commit 12d7330.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    fafb34b View commit details
    Browse the repository at this point in the history

  24. Revert "Revert "Assert nil when linking events"" 

    This reverts commit 9ee7904.
    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c0ce593 View commit details
    Browse the repository at this point in the history

  25. NullMapper no longer makes sense without serilizaion in mappers

    @mostlyobvious
    mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    6f4540c View commit details
    Browse the repository at this point in the history

  26. Ensure only supported any usage by default 

    Breaks backwards compatibility, so to be merged with RES 3.x.

We may also consider adding some configuration option to turn it off.
    @swistak35 @mostlyobvious
    swistak35 authored and mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    49fd635 View commit details
    Browse the repository at this point in the history

  27. Revert "Remove rename warning" 

    This reverts commit b76e96c.
    @lukaszreszke @mostlyobvious
    lukaszreszke authored and mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    e2d8105 View commit details
    Browse the repository at this point in the history

  28. Revert "Kill mutants" 

    This reverts commit 11157ed.
    @lukaszreszke @mostlyobvious
    lukaszreszke authored and mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7d112e8 View commit details
    Browse the repository at this point in the history

  29. Revert "RailsEventStore 2.6.X should point to RailsEventStoreActiveRe… 

    …cord"

This reverts commit e847fac.
    @lukaszreszke @mostlyobvious
    lukaszreszke authored and mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7e78fb2 View commit details
    Browse the repository at this point in the history

  30. Revert "Remove post install deprecation message for rails_event_store… 

    …_active_record"

This reverts commit 057e333.
    @lukaszreszke @mostlyobvious
    lukaszreszke authored and mostlyobvious committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    d6add07 View commit details
    Browse the repository at this point in the history