FIX: fix the bug in negative sampling. #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenglongMa
reviewed
Sep 25, 2023
| @@ -137,7 +137,7 @@ def _set_neg_sample_args(self, config, dataset, dl_format, neg_sample_args): | |||
| self.times = 1 | |||
| if ( | |||
| self.neg_sample_args["distribution"] == "uniform" | |||
| or "popularity" | |||
| or self.neg_sample_args["distribution"] == "popularity" | |||
| and self.neg_sample_args["sample_num"] != "none" | |||
There was a problem hiding this comment.
Hi @zhengbw0324,
This fix is still incorrect. When distribution is uniform, the if condition always returns True no matter what sample_num is.
So I suggest using the method mentioned in the PR:#1863.
Or you can put the self.neg_sample_args["distribution"] == "uniform" or self.neg_sample_args["distribution"] == "popularity" into a parenthesis, i.e.,
if (
( self.neg_sample_args["distribution"] == "uniform"
or self.neg_sample_args["distribution"] == "popularity" ) # <- like this
and self.neg_sample_args["sample_num"] != "none"
):
...Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.