Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add opret anchors when preset to a consignment #272

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

dr-orlovsky
Copy link
Member

Closes #271

I believe it should fix RGB-WG/rgb-tests#6

@dr-orlovsky dr-orlovsky added the bug Something isn't working label Sep 17, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Sep 17, 2024
@dr-orlovsky dr-orlovsky self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0.79365% with 125 lines in your changes missing coverage. Please review.

Project coverage is 19.5%. Comparing base (94aeb57) to head (fc20101).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/persistence/stock.rs 0.0% 32 Missing ⚠️
src/persistence/memory.rs 0.0% 30 Missing ⚠️
src/persistence/state.rs 0.0% 21 Missing ⚠️
src/persistence/stash.rs 0.0% 17 Missing ⚠️
src/containers/indexed.rs 0.0% 12 Missing ⚠️
src/containers/consignment.rs 12.5% 7 Missing ⚠️
src/containers/anchors.rs 0.0% 4 Missing ⚠️
src/persistence/index.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #272     +/-   ##
========================================
+ Coverage    19.2%   19.5%   +0.3%     
========================================
  Files          40      40             
  Lines        8603    8453    -150     
========================================
- Hits         1654    1652      -2     
+ Misses       6949    6801    -148     
Flag Coverage Δ
rust 19.5% <0.8%> (+0.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run the test in RGB-WG/rgb-tests#6 100 times and can confirm the test passed every time, so with this PR there is no more a non-deterministic behavior and transfers spending both tapret and opret allocations work again.

@dr-orlovsky dr-orlovsky merged commit 670a7b6 into master Sep 19, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

receiver fails to accept a transfer which spends opret and tapret allocations together
2 participants