Support spending mixed opret/tapret outputs #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is required to support multiple forms of seals in constructing batches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246
If PSBT inputs contain single-use seals of different types (opret and taproot) spent by the same wallet, we need to create two state transitions - one for tapret and one for opret. The main state transition is the one which matches the type of the wallet descriptor; the other state transition will just transform invalid seal type into correct one allocated to the change output. We also have to construct blank transitions of both types, as needed.
If PSBT is multi-party with wallets of different seal types, this situation doesn't happen since each wallet works and updates PSBT independently and their state transitions does not cross.