Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added demo for sequence of accordion mappings and form item inside pa… #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schattenlink
Copy link

…nel header

@stevepiercy
Copy link
Member

@schattenlink please review our guidelines for making contributions.

This PR lacks tests, so it cannot be accepted in its current state.

@miohtama
Copy link
Contributor

miohtama commented Mar 9, 2017

@stevepiercy No worries. We discussed this privately before opening a PR. I needed to have a proof-of-problem, so that I can fill in both solutions and tests.

@frispete
Copy link
Contributor

frispete commented Mar 9, 2017

@miohtama you might want to urge people to file issues for some such.

@miohtama
Copy link
Contributor

miohtama commented Mar 9, 2017

@frispete Yeah, a fork + branch + issue would have been better. I did not think my instructions throughly.

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm following up on this PR. I don't know whether this is this an actual PR or an example of a bug?

If a PR:

  • Would you please make the spelling corrections?
  • We now use Black to format code. Would you please do that as well?
  • This needs tests.

If part of a bug report, which issue is it?

If there is no issue, would you please create one?

I am working on a release of Deform 3.0, and this would be something worth working on.

Thank you!

@@ -2684,6 +2684,35 @@ class Schema(colander.Schema):

return self.render_form(deform.Form(Schema(), buttons=('submit',)))

@view_config(renderer='templates/form.pt',
name='accordion_as_sequenze_item_and_form_element_inside_mapping_header')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name='accordion_as_sequenze_item_and_form_element_inside_mapping_header')
name='accordion_as_sequence_item_and_form_element_inside_mapping_header')

@@ -2684,6 +2684,35 @@ class Schema(colander.Schema):

return self.render_form(deform.Form(Schema(), buttons=('submit',)))

@view_config(renderer='templates/form.pt',
name='accordion_as_sequenze_item_and_form_element_inside_mapping_header')
@demonstrate('accordion as sequenze item and form element inside mapping header')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@demonstrate('accordion as sequenze item and form element inside mapping header')
@demonstrate('accordion as sequence item and form element inside mapping header')

# application is inside panel header
application = Application()
title = 'open' # to open the accordion
# text is iside panel body
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# text is iside panel body
# text is inside panel body

Base automatically changed from master to main January 19, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants