Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft - PS-1039 - Mapbox attribution displayed #7

Draft
wants to merge 1 commit into
base: stable/1.1.1
Choose a base branch
from

Conversation

edupazpix4d
Copy link

@edupazpix4d edupazpix4d commented Oct 27, 2021

Enable Mapbox copyright attribution, following the same approach done by default Qt MapboxGL plugin.

https://docs.mapbox.com/help/getting-started/attribution/

Image_20211027_145655


CustomGeoTiledMap::CustomGeoTiledMap(GeoTiledMappingManagerEngine *engine, QObject *parent) :
QGeoTiledMap(engine, parent) {
setCopyrightVisible(true);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be something you don't want to display if you use custom_urls, right? @viktor-kopp-pix4d @aleksandr-levin-pix4d

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, for custom tile providers it does not make sense to show Mapbox's logo

@edupazpix4d edupazpix4d force-pushed the ps-1039-enable-mapbox-attribution branch from f278bf4 to 93cd442 Compare October 27, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants