Add block clients capability #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerenlahav
reviewed
Aug 8, 2022
TalShorSap
reviewed
Aug 10, 2022
pkg/sm/sm.go
Outdated
|
|
||
| if err := json.Unmarshal(envelope.Data, &blockedClient); err != nil { | ||
| log.C(ctx).Info("error unmarshaling new blocked client") | ||
| } |
There was a problem hiding this comment.
maybe i dont get your logic but if there is an error you are still adding to the cache the client ... ?
sigalmaya
reviewed
Aug 17, 2022
sigalmaya
force-pushed
the
block_client_support
branch
from
ac3aad6
to
16e8c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Prerequisites
Motivation
Describe the problem you're trying to solve or the feature you're proposing in addition to a link to the related issue.
Approach
How does this change address the problem?
Pull Request status
Feel free to construct the checklist with whatever items seem most reasonable for your change. You could disassemble the Implementation part to even smaller separate checklist items if you're working on something big for example. But do make the effort to provide a checklist of some sort so that the core team as well as the community can have an idea about the progress of your Pull Request.
Third-party code
If you use third party code with your contribution such as, components, libraries, or snippets make sure to mention that.
Make sure that your contribution complies with our Contribution guidelines.
Work in Progress label
For as long as development of your Pull Request is still ongoing you MUST label it with a wip label as well as prefix the name of the PR with [WIP].
For example: [WIP] Service brokers API