Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of P-tuning official sample error #8884

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

guangyunms
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Description

fix the bug #8883 , change one function convert_ids_to_words in legacy/examples/few_shot/p-tuning/data.py

Copy link

paddle-bot bot commented Aug 6, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.36%. Comparing base (6235fcd) to head (35ce21e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8884      +/-   ##
===========================================
+ Coverage    55.29%   55.36%   +0.07%     
===========================================
  Files          631      631              
  Lines        98888    98888              
===========================================
+ Hits         54681    54751      +70     
+ Misses       44207    44137      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guangyunms
Copy link
Contributor Author

请问如何通过codecov的target 58.00%的限制,我就调整了一行代码,其它并没有改动?

@wawltor
Copy link
Collaborator

wawltor commented Aug 7, 2024

请问如何通过codecov的target 58.00%的限制,我就调整了一行代码,其它并没有改动?

可以先把workflow.yml去掉,上面的单测覆盖率要求不是required的;删除workflow.yml后我们来review代码以及合入

@guangyunms
Copy link
Contributor Author

请问如何通过codecov的target 58.00%的限制,我就调整了一行代码,其它并没有改动?

可以先把workflow.yml去掉,上面的单测覆盖率要求不是required的;删除workflow.yml后我们来review代码以及合入

已删除workflow.yml

@wawltor
Copy link
Collaborator

wawltor commented Aug 7, 2024

请问如何通过codecov的target 58.00%的限制,我就调整了一行代码,其它并没有改动?

可以先把workflow.yml去掉,上面的单测覆盖率要求不是required的;删除workflow.yml后我们来review代码以及合入

Thank you very much for contributing your code to the PaddleNLP project. Your contribution is highly valuable to us.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 678843e into PaddlePaddle:develop Aug 7, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants