Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java: added iot3core and iot3mobility libs to the project - dependenc… #142

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

nbuffon
Copy link
Member

@nbuffon nbuffon commented Jul 9, 2024

What's new

How to test

TODO

@nbuffon nbuffon added the Java label Jul 9, 2024
@nbuffon nbuffon added this to the Sprint 1 milestone Jul 9, 2024
@nbuffon nbuffon requested a review from fredOG-2A1 July 31, 2024 07:17
Copy link
Member

@fredOG-2A1 fredOG-2A1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost only 'cosmetics' advices given by [SonarLint][Qodana] through Intellij IDE.

}
}

public ArrayList<SensorObject> getSensorObjects() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SonarLint] The return type of this method should be an interface such as "List" rather than the implementation "ArrayList".

return cpm;
}

public void updateSensorObjects(ArrayList<PerceivedObject> perceivedObjects) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SonarLint] The type of "perceivedObjects" should be an interface such as "List" rather than the implementation "ArrayList".

@mathieu1fb mathieu1fb force-pushed the development branch 2 times, most recently from e72f327 to 3b1b822 Compare August 14, 2024 09:09
java/iot3mobility: clean CAM class and subclasses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Connect user equipment to message broker
4 participants