Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rector: added dependency and basic rules #4213

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rector: added dependency and basic rules #4213

wants to merge 3 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 19, 2024 •
edited
Loading

Description (*)

  • added rector as composer dependeny
  • added rules to config (all these rules have already been used ... nothing new here at all)
  • fixed a few lines (maybe new, or newly dedected)
  • added rector to workflow
  • added ddev & composer shortcuts

ddev:

ddev rector --dry-run
ddev rector

composer:

composer run rector:test
composer run rector:fix

... add a path to this commands to test your own extensions code.

Happy coding :)

@github-actions github-actions bot added environment composer Relates to composer.json ddev labels Sep 19, 2024
@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: GoogleAnalytics Relates to Mage_GoogleAnalytics labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADDISON74 ADDISON74 ADDISON74 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: GoogleAnalytics Relates to Mage_GoogleAnalytics composer Relates to composer.json ddev environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @ADDISON74 @colinmollenhour