-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable: remove unused double foreach loop #4008
base: main
Are you sure you want to change the base?
Conversation
* @var array | ||
*/ | ||
protected $_prices = []; | ||
|
||
/** | ||
* Prepared prices | ||
* | ||
* @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but only is set, it is never used (that's why i didn't removed the variables yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hanmac true, should the _preparePrice call be removed too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yeah, but that might be for later MR
after reading the code I did a few tests and couldn't see any problem |
Description (*)
The double
foreach
does nothing of value inside the Block:$this->_preparePrice
which just does format the price value.$_prices
variable hasn't been working for 16 years since Magento 1.1 when this file was created.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)