-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixture lupo/1120-dmx-dual-color
#4178
base: master
Are you sure you want to change the base?
Conversation
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ lupo / 1120-dmx-dual-color: d-light / attributes-correctness
✔️ lupo / 1120-dmx-dual-color: dmxcontrol3 / channel-numbers
❌ lupo / 1120-dmx-dual-color: dragonframe / json-schema-conformity
❌ lupo / 1120-dmx-dual-color: millumin / json-schema-conformity
✔️ lupo / 1120-dmx-dual-color: qlcplus_4.12.2 / fixture-tool-validation
✔️ lupo / 1120-dmx-dual-color: qlcplus_4.12.2 / xsd-schema-conformity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, or as good as we can do given the brief documentation.
"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json", | ||
"name": "1120 DMX Dual Color", | ||
"shortName": "Lupoled 1120", | ||
"categories": ["Dimmer"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"categories": ["Dimmer"], | |
"categories": ["Other"], |
We've seen so many of these photography/videography CCT panels that I think we should have an official category for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would agree. I'll admit I was a little confused when first presented with the categories. Had tried to select Dimmer and Color Changer, as the light can dim and is bi-color, but I can see that those are categories of devices and not just capabilities of the device. There wasn't an obvious category to put it in so I'd just selected Dimmer.
Was curious about this failed check: That's an odd one to fail, given that the fixture's DMX interface is a pair of RJ45 ports. I connect it to other 5-pin DMX devices via an adapter. |
RJ45 was a relatively recent addition to the schema (#3831). Is this another case where the web software simply hasn't picked up the latest version yet? |
lupo/1120-dmx-dual-color
Thank you @quister!