Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture lupo/1120-dmx-dual-color #4178

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture lupo/1120-dmx-dual-color

Thank you @quister!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Aug 28, 2024
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ lupo / 1120-dmx-dual-color: d-light / attributes-correctness
  • ✔️ lupo/1120-dmx-dual-color-CCT.xml
✔️ lupo / 1120-dmx-dual-color: dmxcontrol3 / channel-numbers
  • ✔️ lupo-1120-dmx-dual-color-CCT.xml
lupo / 1120-dmx-dual-color: dragonframe / json-schema-conformity
  • ❌ lupo/1120-dmx-dual-color.jsonfixture/physical/DMXconnector "RJ45" must be equal to one of [3-pin, 3-pin (swapped +/-), 3-pin XLR IP65, 5-pin, 5-pin XLR IP65, 3-pin and 5-pin, 3.5mm stereo jack]
  • ✔️ manufacturers.json
lupo / 1120-dmx-dual-color: millumin / json-schema-conformity
  • ❌ lupo/1120-dmx-dual-color.jsonfixture/physical/DMXconnector "RJ45" must be equal to one of [3-pin, 5-pin, 3-pin (swapped +/-), 3-pin and 5-pin, 3-pin XLR IP65, 3.5mm stereo jack]
✔️ lupo / 1120-dmx-dual-color: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Lupo-1120-DMX-Dual-Color.qxf
✔️ lupo / 1120-dmx-dual-color: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Lupo-1120-DMX-Dual-Color.qxf

Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, or as good as we can do given the brief documentation.

"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json",
"name": "1120 DMX Dual Color",
"shortName": "Lupoled 1120",
"categories": ["Dimmer"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"categories": ["Dimmer"],
"categories": ["Other"],

We've seen so many of these photography/videography CCT panels that I think we should have an official category for them.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree. I'll admit I was a little confused when first presented with the categories. Had tried to select Dimmer and Color Changer, as the light can dim and is bi-color, but I can see that those are categories of devices and not just capabilities of the device. There wasn't an obvious category to put it in so I'd just selected Dimmer.

@quister
Copy link

quister commented Aug 29, 2024

Was curious about this failed check:
❌ lupo/1120-dmx-dual-color.json
fixture/physical/DMXconnector "RJ45" must be equal to one of [3-pin, 3-pin (swapped +/-), 3-pin XLR IP65, 5-pin, 5-pin XLR IP65, 3-pin and 5-pin, 3.5mm stereo jack]

That's an odd one to fail, given that the fixture's DMX interface is a pair of RJ45 ports. I connect it to other 5-pin DMX devices via an adapter.

@kengruven
Copy link
Contributor

RJ45 was a relatively recent addition to the schema (#3831). Is this another case where the web software simply hasn't picked up the latest version yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants