Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system76 galp5-1650 #1126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add system76 galp5-1650 #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,8 @@ See code for all available configurations.
| [Supermicro X12SCZ-TLN4F](supermicro/x12scz-tln4f) | `<nixos-hardware/supermicro/x12scz-tln4f>` |
| [System76 (generic)](system76) | `<nixos-hardware/system76>` |
| [System76 Darter Pro 6](system76/darp6) | `<nixos-hardware/system76/darp6>` |
| [System76 Gazelle Gaze18](system76/gaze18) | `<nixos-hardware/system76/gaze18>` |
| [System76 Gazelle 18](system76/gaze18) | `<nixos-hardware/system76/gaze18>` |
ahoneybun marked this conversation as resolved.
Show resolved Hide resolved
| [System76 Galago Pro 5](system76/galp5-1650) | `<nixos-hardware/system76/galp5-1650>` |
| [Toshiba Chromebook 2 `swanky`](toshiba/swanky) | `<nixos-hardware/toshiba/swanky>` |
| [Tuxedo InfinityBook v4](tuxedo/infinitybook/v4) | `<nixos-hardware/tuxedo/infinitybook/v4>` |
| [TUXEDO InfinityBook Pro 14 - Gen7](tuxedo/infinitybook/pro14/gen7) | `<nixos-hardware/tuxedo/infinitybook/pro14/gen7>` |
Expand Down
1 change: 1 addition & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@
supermicro-x12scz-tln4f = import ./supermicro/x12scz-tln4f;
system76 = import ./system76;
system76-gaze18 = import ./system76/gaze18;
system76-galp5-1650 = import ./system76/galp5-1650;
system76-darp6 = import ./system76/darp6;
toshiba-swanky = import ./toshiba/swanky;
tuxedo-infinitybook-v4 = import ./tuxedo/infinitybook/v4;
Expand Down
27 changes: 27 additions & 0 deletions system76/galp5-1650/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{ config, lib, pkgs, ... }:
{
imports = [
../.
../../common/gpu/nvidia/prime.nix
../../common/gpu/nvidia/ampere
];

boot.initrd.kernelModules = [ "nvidia" ];
Mic92 marked this conversation as resolved.
Show resolved Hide resolved

hardware.graphics = {
enable = lib.mkDefault true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not enabled by the nividia module?

enable32Bit = lib.mkDefault true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am bit unsure if this is actually hardware configuration and not just about playing old games, which not everyone does:

Suggested change
enable32Bit = lib.mkDefault true;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure Steam will need it in general as it needs 32bit even if you have modern games.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but than if we enable the module everywhere, should we not just do it in one place? i.e. nvidia.nix?

};

hardware.nvidia = {

# modesetting.enable = lib.mkDefault true;

powerManagement.finegrained = lib.mkDefault true;

prime = {
intelBusId = "PCI:0:2:0";
nvidiaBusId = "PCI:23:0:0";
};
};
}