Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim to support the GTK_FRAME_EXTENTS (enables full GTK CSD) #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jalopezg-git
Copy link

@jalopezg-git jalopezg-git commented Dec 12, 2023

Advertise support for the GTK_FRAME_EXTENTS property via NET_SUPPORTED. The property, however, is ignored if set, but just advertising support enables full GTK client-side decoration, i.e. rounded corners and drop shadows.

Additional bits and pieces might be landed in a follow-up commit. I don't know if openbox is still maintained, @Mikachu , but let me know whether having that as part of this PR is a must.

Before this patch:
before

After this patch:
after

Both pictures were taken running Openbox and Compton as the composition manager.

Advertise support for the `GTK_FRAME_EXTENTS` property via `NET_SUPPORTED`.
The property, however, is ignored if set, but just advertising support
enables full GTK client-side decoration, i.e. rounded corners and drop
shadows.

Additional bits and pieces might be landed in a follow-up commit.
@jalopezg-git
Copy link
Author

Just a gentle reminder of a pending review on this PR, @Mikachu, @danakj.

Other than that, Happy New 2024 🎉!

@jalopezg-git
Copy link
Author

jalopezg-git commented May 13, 2024

@Mikachu, @danakj just a gentle reminder of this PR (I know at least a person that will find this useful if merged 🙂)!

Have a nice day!

@artebin
Copy link

artebin commented Jun 29, 2024

Thanks @jalopezg-git !
I am not a big fan of the GNOME client side decorations but it is good to see them painted properly with Openbox.
Hope this change can be merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants