Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android loader can display on top of login screen #11325

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Sep 19, 2024

Description

This PR prevents the loading modal to display on top of the login screen.
Also cleanup unnecessary logs.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@abretonc7s abretonc7s requested review from a team as code owners September 19, 2024 15:23
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant