-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update eth-{simple,hd,snap}-keyring + keyring-api #4713
Draft
ccharly
wants to merge
1
commit into
main
Choose a base branch
from
feature/use-new-accounts-packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
force-pushed
the
feature/use-new-accounts-packages
branch
from
September 18, 2024 15:59
56326ab
to
067f2f0
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
ccharly
force-pushed
the
feature/use-new-accounts-packages
branch
from
September 19, 2024 09:47
067f2f0
to
bff78ca
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Those new versions have been created using the new
accounts
monorepo.We are updating them to make sure this new way of building those packages has no unintended side-effects.
References
Related to:
Changelog
@metamask/keyring-controller
@metamask/eth-hd-keyring
to ^7.0.2@metamask/eth-simple-keyring
to ^6.0.3@metamask/keyring-api
to ^8.1.1@metamask/accounts-controller
@metamask/eth-snap-keyring
to ^4.3.4@metamask/keyring-api
to ^8.1.1@metamask/assets-controller
@metamask/keyring-api
to ^8.1.1@metamask/chain-controller
@metamask/keyring-api
to ^8.1.1@metamask/transaction-controller
@metamask/keyring-api
to ^8.1.1@metamask/profile-sync-controller
@metamask/keyring-api
to ^8.1.1Checklist