chore: merge upstream #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne#20997) (fastlane#20998) Fix issue with releases containing retained versions failing to complete the staged rollout in the Google Play Store.
* Do not print output of find-certificate * Added print parameter to backticks * Fixed styling of hash * Reverted changes to FastlaneSwiftRunner.xcodeproj --------- Co-authored-by: Duncan MacDonald <[email protected]>
…fastlane#21409) * [match] remove redundant fetching of profile devices and certificates * chore: add device accessor to profile.rb
* Notarization - Printing log on error * Notarization - Printing log on error * Notarization - Printing log on error * Notarization - Printing log on error * Notarization - Printing log on error * Notarization - Printing log on error
* Work around deliver issue fastlane#21105 * Adjust code for rubocop
…stlane#21618) Main changes: * Let FastlanePty detect when externally invoked programs crash * Harden it when using popen * Expose process_status into FastlanePtyError * Add unit tests * Add a helper C program used to investigate ruby behavior
…o upload (fastlane#21657) * fix(deliver): fix issue where privacy url change fails to upload * fix code style * add test
* Remove 'warning: already initialized constant ScreenSize' * Remove warning of rspec raise_error being used too widely * Remove warning related to rspec around usage * Reduce amount of deprecation output. * Remove chruby as we are not installing it. Is it needed? * Rubocop fix * Update spaceship/spec/tunes/device_type_spec.rb Co-authored-by: Roger Oba <[email protected]> * Clean comment --------- Co-authored-by: Roger Oba <[email protected]>
* Activate ruby 3.2.2 on circlea * circle doc * Update rspec and webmock to pass tests on ruby 3.2+ * require SyntaxError content changed in ruby 3.2 * circle: Run tests on latest xcode version * rubocop * webmock 3.19.1 breaks tests * Find a version of webmock that works, and make the tests pass by passing the expected hash instead of keywords * Better document the difference between ruby 3.1 and 3.2
* Rewrite changelog_from_git_commits_spec test that outputs to STDOUT * Disable Helper.show_loading_indicator in test output * Disable Helper.show_loading_indicator in test output * Hide warnings and other errors into standard output, hidden during tests * Prevent code from generating unecessary output in tests * Remove WARNING from stdout. * Fastlane::CLIToolsDistributor remove output from tests * Disable output messages that pops up in newer git init setup * hide the swift --version generated stderr output * Take into account code review * Move stdout/stderr hiding into command generation * Improve the code that disables the UpdateChecker * Cleanup unecessary .to_s * Improve the test setup to avoid side effects with ENV
On ruby 3.1.4 there is issue with dependency tree: ```Uncaught exception: You have already activated optparse 0.2.0, but your Gemfile requires optparse 0.1.1. Since optparse is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports optparse as a default gem.``` `optparse` is a standard gem https://stdgems.org/optparse/ that has higher versions in newer ruby
How about using dependabot in this way? When this works, a pull request is created as follows: - ruby/bigdecimal#242 It was created with reference to the following: - ruby/csv#265
) Bumps [mislav/bump-homebrew-formula-action](https://github.com/mislav/bump-homebrew-formula-action) from 1.4 to 3.1. - [Release notes](https://github.com/mislav/bump-homebrew-formula-action/releases) - [Commits](mislav/bump-homebrew-formula-action@v1.4...v3.1) --- updated-dependencies: - dependency-name: mislav/bump-homebrew-formula-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fastlane is no longer under the auspices of Google[^1]. Completing the Google Contributor License Agreement is no longer required. [^1]: MobileNativeFoundation/discussions#194
…tentially fixing signal kill before running tests (fastlane#21026)
…tlane#21032) Similar to the Pilot fix here: fastlane#9481
* Add parallel option to spm action * Add parallel test example * Change boolean option from optional to default false. --------- Co-authored-by: Roger Oba <[email protected]>
…y and shallow_clone (fastlane#21716) * [match] combine clone_branch_directly and shallow_clone * fix: typo Co-authored-by: Roger Oba <[email protected]> * chore: refactor git_storage tests * Remove parenthesis around "it" statements. --------- Co-authored-by: Roger Oba <[email protected]>
…`, as recommended by Swift CLI (fastlane#20814) * Deprecate spm's build_path option * Add deprecated message when use build_path on spm action Co-authored-by: Josh Holtz <[email protected]> * Remove unnecessary warning message --------- Co-authored-by: Josh Holtz <[email protected]> Co-authored-by: Jerome Lacoste <[email protected]>
* Reformat code for readability * Remove unused env parameter in cruise_lane calls * Remove unused parameter * Remove unused parameter * Remove unused parameter
* Relax regular expression that captures compilation error to be compatible with ruby 3.3 * Relax regular expression that captures compilation error to be compatible with ruby 3.3 * Change the way we build the test and its expected results to accomodate for internal changes in ruby 3.3 evaluation of __FILE__ within the eval() call * Update fastlane/spec/plugins_specs/plugin_generator_spec.rb Co-authored-by: Roger Oba <[email protected]> --------- Co-authored-by: Roger Oba <[email protected]>
…to 100x (fastlane#21694) * [match] increase match speed with caching * chore: skip new profile validation * chore: don’t install a nonexistent profile * chore: code readability improvements * chore: improve cert & device difference * chore: fix variable naming * chore: remove redundant var init * chore: check for unique profiles * fix: typo * chore: match portal bundle id fetcher expect only arrays * fix: only uuids with one hyphen supported for silicon macs * chore: add comment about cert type downcasing Co-authored-by: Roger Oba <[email protected]> * chore: use standard syntax for multiline blocks * chore: remove empty it * chore: update cache returns * chore: extra check for cached certs after reset --------- Co-authored-by: Roger Oba <[email protected]>
… to `Gemfile.erb` (fastlane#21726) * Make Gemfile a template and move dev dependencies to it, in plugin generator. * Remove now-unnecessary rule exception on RuboCop. * Update comments.
…ive Xcode installation when choosing default (fastlane#21677) * [scan] Filter simulators with version greater than currently installed SDK * addressing feedback * redo implementation using suggested CLI invocations * better description for test case * addressing feedback * move runtime_build_os_versions into own function * fix odd indentation
…xecutor crashes (fastlane#21536) * Force FastlanePty.spawn to return exit code if it ends up being nil for whatever reason * Actually, let's implement the fix right where the problem occurs, and add a test * Update fastlane_core/lib/fastlane_core/itunes_transporter.rb Co-authored-by: Aaron Brager <[email protected]> * Remove unneeded nil catch given fastlane#21618 * Write more accurate test --------- Co-authored-by: Aaron Brager <[email protected]>
fastlane#21709) * Sync Gemfile.lock with Gemfile * Update rack to >= 2.2.6.3 (dependenbot) * Update sinatra to >= 2.2.3 (dependenbot) * Restrict to a non major sinatra upgrade for now
…astlane#21725) * Move development dependencies from gemspec to Gemfile, as recommended. * Make the default rubocop configuration explicit to show intentional decision.
…astlane#21735) * Update image of the validate_documentation workflow to fix CI. * Refactor name of workflow parameters so they're more accurate.
* Lint GitHub Actions yaml files and add comments. * Review workflow names and comments.
* Add simulator flag to spm action for swift compiler * add user entry syntax check * removing ipadsimulator from syntax check * Adding verify_block for flag check * adding simulators list to user_error * Update fastlane/lib/fastlane/actions/spm.rb Co-authored-by: Roger Oba <[email protected]> * Update fastlane/lib/fastlane/actions/spm.rb Co-authored-by: Roger Oba <[email protected]> * Adding unit tests for simulator * Fix simulator typo * Update fastlane/spec/actions_specs/spm_spec.rb Co-authored-by: Roger Oba <[email protected]> * Fix typo. * Adding support for different simulator architecture * Adding unit tests for simulator architecture * Modify code by extracting the logic into methods * Update fastlane/lib/fastlane/actions/spm.rb Co-authored-by: Roger Oba <[email protected]> * Update fastlane/lib/fastlane/actions/spm.rb Co-authored-by: Roger Oba <[email protected]> --------- Co-authored-by: Roger Oba <[email protected]>
…ne#21747) * Fix linter issue that slipped to master, and simplify string declaration. * Fix syntax issue in example code caught by docs validation.
…he workflows (fastlane#21746) * Add back ruby_version parameter to CircleCI workflows. * Add a more descriptive name to CircleCI GitHub Check. * Test if string with spaces is allowed as identifier.
…oken (fastlane#21736) Co-authored-by: Goffredo Marocchi <[email protected]> Co-authored-by: Roger Oba <[email protected]>
…ase, documentation and specs (fastlane#19495) * spelling: accept Signed-off-by: Josh Soref <[email protected]> * spelling: acknowledge Signed-off-by: Josh Soref <[email protected]> * spelling: adaptations Signed-off-by: Josh Soref <[email protected]> * spelling: already Signed-off-by: Josh Soref <[email protected]> * spelling: attempts Signed-off-by: Josh Soref <[email protected]> * spelling: available Signed-off-by: Josh Soref <[email protected]> * spelling: backed up Signed-off-by: Josh Soref <[email protected]> * spelling: boolean Signed-off-by: Josh Soref <[email protected]> * spelling: build Signed-off-by: Josh Soref <[email protected]> * spelling: candidate Signed-off-by: Josh Soref <[email protected]> * spelling: capability Signed-off-by: Josh Soref <[email protected]> * spelling: catch/return Signed-off-by: Josh Soref <[email protected]> * spelling: characters Signed-off-by: Josh Soref <[email protected]> * spelling: collapsible Signed-off-by: Josh Soref <[email protected]> * spelling: command-line Signed-off-by: Josh Soref <[email protected]> * spelling: commands Signed-off-by: Josh Soref <[email protected]> * spelling: contains Signed-off-by: Josh Soref <[email protected]> * spelling: convenient Signed-off-by: Josh Soref <[email protected]> * spelling: copies Signed-off-by: Josh Soref <[email protected]> * spelling: default Signed-off-by: Josh Soref <[email protected]> * spelling: deleted Signed-off-by: Josh Soref <[email protected]> * spelling: deprecated Signed-off-by: Josh Soref <[email protected]> * spelling: destination Signed-off-by: Josh Soref <[email protected]> * spelling: directories Signed-off-by: Josh Soref <[email protected]> * spelling: does Signed-off-by: Josh Soref <[email protected]> * spelling: early Signed-off-by: Josh Soref <[email protected]> * spelling: enqueued Signed-off-by: Josh Soref <[email protected]> * spelling: error Signed-off-by: Josh Soref <[email protected]> * spelling: evaluate Signed-off-by: Josh Soref <[email protected]> * spelling: exclude Signed-off-by: Josh Soref <[email protected]> * spelling: family Signed-off-by: Josh Soref <[email protected]> * spelling: faraday Signed-off-by: Josh Soref <[email protected]> * spelling: foo Signed-off-by: Josh Soref <[email protected]> * spelling: function Signed-off-by: Josh Soref <[email protected]> * spelling: groups Signed-off-by: Josh Soref <[email protected]> * spelling: identifier Signed-off-by: Josh Soref <[email protected]> * spelling: identifying Signed-off-by: Josh Soref <[email protected]> * spelling: identities Signed-off-by: Josh Soref <[email protected]> * spelling: ignore Signed-off-by: Josh Soref <[email protected]> * spelling: individual Signed-off-by: Josh Soref <[email protected]> * spelling: infrequent Signed-off-by: Josh Soref <[email protected]> * spelling: integer Signed-off-by: Josh Soref <[email protected]> * spelling: mapping Signed-off-by: Josh Soref <[email protected]> * spelling: milliseconds Signed-off-by: Josh Soref <[email protected]> * spelling: modified Signed-off-by: Josh Soref <[email protected]> * spelling: multiple Signed-off-by: Josh Soref <[email protected]> * spelling: nonexistent Signed-off-by: Josh Soref <[email protected]> * spelling: normalized Signed-off-by: Josh Soref <[email protected]> * spelling: original Signed-off-by: Josh Soref <[email protected]> * spelling: originating Signed-off-by: Josh Soref <[email protected]> * spelling: output Signed-off-by: Josh Soref <[email protected]> * spelling: platform Signed-off-by: Josh Soref <[email protected]> * spelling: portrait Signed-off-by: Josh Soref <[email protected]> * spelling: practices Signed-off-by: Josh Soref <[email protected]> * spelling: priority Signed-off-by: Josh Soref <[email protected]> * spelling: probably Signed-off-by: Josh Soref <[email protected]> * spelling: properly Signed-off-by: Josh Soref <[email protected]> * spelling: provisioning Signed-off-by: Josh Soref <[email protected]> * spelling: quote Signed-off-by: Josh Soref <[email protected]> * spelling: reached Signed-off-by: Josh Soref <[email protected]> * spelling: reenable Signed-off-by: Josh Soref <[email protected]> * spelling: rejected Signed-off-by: Josh Soref <[email protected]> * spelling: representing Signed-off-by: Josh Soref <[email protected]> * spelling: represents Signed-off-by: Josh Soref <[email protected]> * spelling: returns Signed-off-by: Josh Soref <[email protected]> * spelling: screenshot Signed-off-by: Josh Soref <[email protected]> * spelling: screenshots Signed-off-by: Josh Soref <[email protected]> * spelling: secondary Signed-off-by: Josh Soref <[email protected]> * spelling: set Signed-off-by: Josh Soref <[email protected]> * spelling: shuts down Signed-off-by: Josh Soref <[email protected]> * spelling: signature Signed-off-by: Josh Soref <[email protected]> * spelling: simplify Signed-off-by: Josh Soref <[email protected]> * spelling: spaceship Signed-off-by: Josh Soref <[email protected]> * spelling: specified Signed-off-by: Josh Soref <[email protected]> * spelling: string if Signed-off-by: Josh Soref <[email protected]> * spelling: studio Signed-off-by: Josh Soref <[email protected]> * spelling: succeeds Signed-off-by: Josh Soref <[email protected]> * spelling: successfully Signed-off-by: Josh Soref <[email protected]> * spelling: suppress Signed-off-by: Josh Soref <[email protected]> * spelling: syntax Signed-off-by: Josh Soref <[email protected]> * spelling: triggered Signed-off-by: Josh Soref <[email protected]> * spelling: unauthorized Signed-off-by: Josh Soref <[email protected]> * spelling: unique Signed-off-by: Josh Soref <[email protected]> * spelling: unprocessable Signed-off-by: Josh Soref <[email protected]> * spelling: upload Signed-off-by: Josh Soref <[email protected]> * spelling: uploaded Signed-off-by: Josh Soref <[email protected]> * spelling: verbose Signed-off-by: Josh Soref <[email protected]> * spelling: version Signed-off-by: Josh Soref <[email protected]> * spelling: whether Signed-off-by: Josh Soref <[email protected]> * spelling: with Signed-off-by: Josh Soref <[email protected]> * spelling: without Signed-off-by: Josh Soref <[email protected]> * Use plural version of `env_names` and add backwards compatible env var identifiers. * Revert changes made to `Fastlane.swift` autogenerated file. * Improve wording. * Use plural version of `env_names` and add backwards compatible env var identifiers. * spelling: already Signed-off-by: Josh Soref <[email protected]> * spelling: anymore Signed-off-by: Josh Soref <[email protected]> * spelling: are Signed-off-by: Josh Soref <[email protected]> * spelling: backed up Signed-off-by: Josh Soref <[email protected]> * spelling: be Signed-off-by: Josh Soref <[email protected]> * spelling: cannot Signed-off-by: Josh Soref <[email protected]> * spelling: case-insensitive Signed-off-by: Josh Soref <[email protected]> * spelling: doubled Signed-off-by: Josh Soref <[email protected]> * spelling: emulate Signed-off-by: Josh Soref <[email protected]> * spelling: entry Signed-off-by: Josh Soref <[email protected]> * spelling: equal Signed-off-by: Josh Soref <[email protected]> * spelling: every time Signed-off-by: Josh Soref <[email protected]> * spelling: exclude Signed-off-by: Josh Soref <[email protected]> * spelling: existence Signed-off-by: Josh Soref <[email protected]> * spelling: far, far Signed-off-by: Josh Soref <[email protected]> * spelling: fine-grained Signed-off-by: Josh Soref <[email protected]> * spelling: for Signed-off-by: Josh Soref <[email protected]> * spelling: github Signed-off-by: Josh Soref <[email protected]> * spelling: gitlab Signed-off-by: Josh Soref <[email protected]> * spelling: identifying Signed-off-by: Josh Soref <[email protected]> * spelling: indicates Signed-off-by: Josh Soref <[email protected]> * spelling: macos Signed-off-by: Josh Soref <[email protected]> * spelling: matching Signed-off-by: Josh Soref <[email protected]> * spelling: minimally Signed-off-by: Josh Soref <[email protected]> * spelling: nonexistent Signed-off-by: Josh Soref <[email protected]> * spelling: parallel Signed-off-by: Josh Soref <[email protected]> * spelling: perform Signed-off-by: Josh Soref <[email protected]> * spelling: purchase Signed-off-by: Josh Soref <[email protected]> * spelling: resolution Signed-off-by: Josh Soref <[email protected]> * spelling: respond Signed-off-by: Josh Soref <[email protected]> * spelling: returns Signed-off-by: Josh Soref <[email protected]> * spelling: shellwords Signed-off-by: Josh Soref <[email protected]> * spelling: sierra Signed-off-by: Josh Soref <[email protected]> * spelling: squiggly Signed-off-by: Josh Soref <[email protected]> * spelling: still Signed-off-by: Josh Soref <[email protected]> * spelling: the Signed-off-by: Josh Soref <[email protected]> * spelling: through Signed-off-by: Josh Soref <[email protected]> * spelling: universal Signed-off-by: Josh Soref <[email protected]> * spelling: unsuitable Signed-off-by: Josh Soref <[email protected]> * spelling: using Signed-off-by: Josh Soref <[email protected]> * spelling: with Signed-off-by: Josh Soref <[email protected]> * spelling: work around Signed-off-by: Josh Soref <[email protected]> * spelling: workaround Signed-off-by: Josh Soref <[email protected]> * spelling: working Signed-off-by: Josh Soref <[email protected]> * spelling: data_for_app_store_versions Signed-off-by: Josh Soref <[email protected]> * Reverting changes to Fastlane.swift * Improving comment * spelling: time, Signed-off-by: Josh Soref <[email protected]> * spelling: of the dsym Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Roger Oba <[email protected]>
* fix: sigh cache validation parameters * fix: needs_profiles_devices resoling in portal cache * chore: fix nil devices and certificates
Fixes fastlane#21768 when there is no device match for a given name.
* [ci] fix homebrew bump url * Need to run brew update before bump
…to use specified ruby versions (fastlane#21777) * [fastlane][ci] Lock google-cloud-env < 2.0.0 for Ruby 2.6 and fix CI to use specified ruby versions * 1.6, not 1.7 * Fix CircleCI ruby versions * Oops
# Conflicts: # match/lib/match/runner.rb # match/lib/match/spaceship_ensure.rb # match/spec/runner_spec.rb # sigh/lib/sigh/runner.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging latest fastlane release