Live release + libcore 4.2 #763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently all advertised/signed fees are consumed in transaction and no ratio of actual gas usage is used regarding fee computation
If we do not fetch the block data each time a transaction is fetched (although saving HTTP calls), then : - The blockHash of the transaction is empty, therefore no block_uid can be computed from the tx.block - The block_uid column of the transaction in the database therefore stays `NULL` - When querying the operations later, the LEFT JOIN of cosmos_transactions with blocks will fail to find a block - Final state : the queried operation has no "height" information Having no "height" information is a problem because this is used by Ledger Live to compute the count of confirmations for a given Operation.
Added a test on fetched operations block height during synchronization to prevent regressions.
Since the sizes of the containers match, we can just overwrite the transactions vector using the `begin` iterator in the transform (and no erase necessary either, since the sizes match)
This fixes an issue where the "getSequence()" call was not up to date when called more often than the full account synchronization. The update is _not_ called on getAccountNumber() since this value is immutable.
This reverts commit a99d894.
This reverts commit a99d894.
Remove some unnecessary log
Add some debug log
Add some debug log
add more debug log
Remove some log
Add some debug log
Add some debug log
Add some debug log
add some debug log
Add some debug log
add some debug log
Fix block empty bug
Remove some log
Remove some log
Revert commit b53bdfb to fix live error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.