Bitcoin Feature #355
Bitcoin Feature #355
Conversation
| throw make_exception(api::ErrorCode::INVALID_ARGUMENT, "No change path provided by user."); | ||
| } | ||
| auto it = buddy->request.changePaths.back(); | ||
| return std::stoul(it.substr(it.find_last_of('/') + 1), nullptr, 0); |
There was a problem hiding this comment.
Which version of c++ we are using here ? Because you can remove the substring construction by using the new std::string_view.
More than that, I think there is a bug. If the last changePaths doesn't have any '/', find_last_of returns string::npos which is the maximum value to size_t so when you add 1 to that value, you got a 0 and your stoul call returns 0.
This is what you want ?
There was a problem hiding this comment.
It’s a C++17 feature. We can’t use it.
There was a problem hiding this comment.
@phaazon Hence my question to @KhalilBellakrid ;)
There was a problem hiding this comment.
We use C++14 so .. SFYL ! 
Concerning the behaviour, yes this is exactly what I'm looking for, we want support all ways of setting paths, user can input 0/1/8, 1/8 or 8 and we will always retrieve the right index, if someone inputs 8/ or some other invalid path then we would throw an exception on the stoul hence the encapsulation in the Try and in that case we would fall back on previous behaviour (getting a fresh change address)
|
@KhalilBellakrid you got two approvals, so you can merge — unless you wanna investigate those failing builds. |
|
|
Support choosing change address path.