VG-750 fix(explorer): Return explorer error in broadcast error message (

#936)
LedgerHQ · May 31, 2023 · d98d283 · d98d283
1 parent f5b1422
commit d98d283
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/core/idl/errors.djinni b/core/idl/errors.djinni
@@ -108,6 +108,9 @@ ErrorCode = enum {
 
     # Tezos errors
     invalid_self_tx;
+
+    # Exolorer errors
+    explorer_error;
 }
 
 Error = record {

diff --git a/core/src/api/ErrorCode.cpp b/core/src/api/ErrorCode.cpp
diff --git a/core/src/api/ErrorCode.hpp b/core/src/api/ErrorCode.hpp
diff --git a/core/src/wallet/bitcoin/explorers/LedgerApiBitcoinLikeBlockchainExplorer.cpp b/core/src/wallet/bitcoin/explorers/LedgerApiBitcoinLikeBlockchainExplorer.cpp
@@ -62,9 +62,12 @@ namespace ledger {
             return _http->POST(fmt::format("/blockchain/{}/{}/transactions/send", getExplorerVersion(), getNetworkParameters().Identifier),
                                std::vector<uint8_t>(bodyString.begin(), bodyString.end()),
                                headers)
-                .json()
+                .json(false, true, false)
                 .template map<String>(getExplorerContext(), [](const HttpRequest::JsonResult &result) -> String {
                     auto &json = *std::get<1>(result);
+                    if (!json.HasMember("result")) {
+                        throw Exception(api::ErrorCode::EXPLORER_ERROR, fmt::format("Got explorer error: {}", json["message"].GetString()));
+                    }
                     return json["result"].GetString();
                 });
         }
@@ -153,4 +156,4 @@ namespace ledger {
         }
 
     } // namespace core
-} // namespace ledger
+} // namespace ledger