Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict_encoding_test crate to replace macros/test_helpers deprecated in strict_encoding 1.6.1 #218

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

philmartin2525
Copy link
Contributor

Addresses #210

Added the strict_encoding_test crate and replaced the macros and functions deprecated in strict_encoding since 1.6.1.

@dr-orlovsky dr-orlovsky added this to the v0.6.0 milestone Jan 25, 2022
@dr-orlovsky dr-orlovsky added test Improvements to test coverage and CI upstream Tasks that require changes to upstream dependecy projects (rust-bitcoin, miniscript, lightning etc) labels Jan 25, 2022
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 107e8d2

Thank you!

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #218 (107e8d2) into master (b87e1d6) will decrease coverage by 1.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #218     +/-   ##
========================================
- Coverage    70.3%   68.4%   -1.9%     
========================================
  Files           5       5             
  Lines        1174    1273     +99     
========================================
+ Hits          825     871     +46     
- Misses        349     402     +53     
Impacted Files Coverage Δ
chain/src/lib.rs 87.5% <ø> (ø)
src/lib.rs 47.2% <0.0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87e1d6...107e8d2. Read the comment docs.

@dr-orlovsky dr-orlovsky merged commit 64d727f into LNP-BP:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Improvements to test coverage and CI upstream Tasks that require changes to upstream dependecy projects (rust-bitcoin, miniscript, lightning etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants