-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caliper annotations to quest_candidates_example #1419
base: develop
Are you sure you want to change the base?
Conversation
Here's an example of the CUDA-BVH output with caliper report:
and an example of the CUDA-Implicit Grid output with caliper report:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -434,6 +446,7 @@ template <typename ExecSpace> | |||
axom::Array<IndexPair> findCandidatesBVH(const HexMesh& insertMesh, | |||
const HexMesh& queryMesh) | |||
{ | |||
AXOM_ANNOTATE_BEGIN("initializing BVH"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Would it make sense to remove the explicit timers now that we have caliper?
Having both will cause the outer wrapper to include timings for the inner one, and in this case, the caliper timings will include the SLIC formatting and logging times.
This PR:
quest_candidates_example
As part of this, also re-ran my test scripts using the same setup as before to get the average numbers (in seconds) for the spatial index performances. In addition, I added numbers for rzwhippet for 112 threads.
Notably, the initialization times for both bvh and implicit grid are an order of magnitude faster than before for HIP and CUDA (previous PR #1278 for comparison):
Same testing setup as last time, but with caliper:
time ./examples/quest_candidates_example_ex -i ucart23z.cycle_000000.root -q ucart23z_shifted.cycle_000000.root -p <raja policy number> -m <method, either "bvh" or "implicit"> --caliper report
flux run -N 1 -g 1
lrun -n 1 -g 1
salloc -N 1 -n 36
for rzgenie,salloc -N 1 -n 112
for rzwhippetucart23z
is an 8,000,000 element mesh, whileucart23z_shifted
is the same mesh but shifted slightly.