Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserveCells crashes mint mesh inside Umpire #1271

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

gunney1
Copy link
Contributor

@gunney1 gunney1 commented Feb 6, 2024

Crash reserving space for UnstructuredMesh

  • This PR is a bug fix
  • It does the following:
    • Adds tests that verify the crash (which happens on our docker platforms)
    • Fix the bug (if it is indeed a bug) or make the code die gracefully

This crash has been plaguing PR #1263. The MarchingCubes test crashes while asking mint::UnstructuredMesh to reserve space. This PR aims to provide a reproducer and correct the crash.

Two identical tests were added:

  • In src/axom/quest/tests/quest_initialize.cpp
  • In src/axom/mint/tests/mint_mesh.cpp

Interesting behaviors:

  • The test added to quest reproduces the crash, but the one added to mint does not.
  • The crashes only occur in our docker builds.
  • Bypassing the memory reserve calls doesn't work for the originating problem. The crash occurs later, when memory allocation takes place.

@gunney1 gunney1 self-assigned this Feb 6, 2024
@gunney1 gunney1 added Sidre Issues related to Axom's 'sidre' component Quest Issues related to Axom's 'quest' component Mint Issues related to Axom's 'mint' component labels Feb 6, 2024
@gunney1 gunney1 force-pushed the bugfix/gunney/ug-immediate-reserve branch from 643c441 to f25bdc4 Compare February 7, 2024 00:36
@gunney1 gunney1 added the bug Something isn't working label Feb 7, 2024
@gunney1 gunney1 added this to the April 2024 Release milestone Feb 7, 2024
@gunney1
Copy link
Contributor Author

gunney1 commented Feb 22, 2024

Some new observations:

  1. Based on @white238's guess, I disabled MPI (and MFEM, which was configured with MPI) from the failing config. This fixed the failure. Not exactly sure what the mechanism of failure was.
  2. I tried to construct the UnstructuredMesh without using Sidre. This also gets past the crash. This provides a work-around for this bug, but it effectively disables some Sidre-dependent features when using the UnstructuredMesh.

@gunney1
Copy link
Contributor Author

gunney1 commented Jun 10, 2024

After merging in the latest develop branch, the failed test (quest_initialize) continues to fail. But if I remove the -DBUILD_SHARED_LIBS=ON from the configuration, the tests pass. @white238 What do you think of this clue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Mint Issues related to Axom's 'mint' component Quest Issues related to Axom's 'quest' component Sidre Issues related to Axom's 'sidre' component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant