Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add results and description testset methods #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmiller-max
Copy link
Member

Closes #3 by defining the abstract type methods in TestReports.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #71 (0f189ac) into master (d4ebb32) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   91.70%   91.89%   +0.18%     
==========================================
  Files           6        6              
  Lines         398      407       +9     
==========================================
+ Hits          365      374       +9     
  Misses         33       33              
Impacted Files Coverage Δ
src/testsets.jl 99.09% <100.00%> (+0.08%) ⬆️
src/to_xml.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ebb32...b15f139. Read the comment docs.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On further thoughts I am not sure if these are required.
Should we table this PR until someone requests it?

Looks fine to me, but maybe it is premature gold plating?
Maybe they would be ok using property overloading?

@mmiller-max
Copy link
Member Author

Yeah make sense, happy to leave for now. I've got a possible use case for it, but also didn't appreciate that you could do property overloading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reports access fields that might not exist for all AbstractTestSet types
2 participants