Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reports access fields that might not exist for all AbstractTestSet types #3

Open
ssfrr opened this issue Jan 9, 2018 · 3 comments · May be fixed by #71
Open

Reports access fields that might not exist for all AbstractTestSet types #3

ssfrr opened this issue Jan 9, 2018 · 3 comments · May be fixed by #71

Comments

@ssfrr
Copy link

ssfrr commented Jan 9, 2018

here and here this assumes that you can get ts.results and ts.description for ts::AbstractTestSet, which won't in general be true. Perhaps we should add results(::AbstractTestSet) and description(::AbstractTestSet) functions to the AbstractTestSet interface (or maybe description could use some kind of string/show method or something.
@ssfrr ssfrr mentioned this issue Jan 9, 2018
Merged
@oxinabox
Copy link
Member

You're right. I was thinking the same thing as I was writing it.
Should that be a method here, or should I escalate it to Base ?

@ssfrr
Copy link
Author

ssfrr commented Jan 10, 2018

I think it should be in Base, and then extended for other testset types (for instance I'd add a method for my ExtendedTestSet).

@oxinabox oxinabox mentioned this issue Jan 10, 2018
Open
@mmiller-max mmiller-max mentioned this issue Jan 7, 2021
Merged
@mmiller-max
Copy link
Member

To fix this, we need abstract methods that both set and access the results and description fields.

@mmiller-max mmiller-max linked a pull request Mar 2, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add results and description testset methods JuliaTesting/TestReports.jl
3 participants
@ssfrr @oxinabox @mmiller-max