Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispatch for rdiv! with LU #55764

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix dispatch for rdiv! with LU #55764

wants to merge 2 commits into from

Conversation

dkarrasch
Copy link
Member

This method (added in #31853) was more specific than the one on line 493, which was added in #31285 at about the same time.

Fixes #55422.

@dkarrasch dkarrasch added performance Must go faster domain:linear algebra Linear algebra backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Sep 13, 2024
@dkarrasch
Copy link
Member Author

This will need to be backported manually...

@dkarrasch dkarrasch removed backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Sep 13, 2024
@dkarrasch
Copy link
Member Author

For the reproducer in the original issue, I get

julia> A = rand(1000,1000); @btime inv($A); @btime inv2($A); @btime inv3($A);
  25.634 ms (10 allocations: 8.13 MiB)
  38.917 ms (9 allocations: 15.27 MiB)
  37.542 ms (9 allocations: 15.27 MiB)

julia> inv(A)  inv2(A)  inv3(A)
true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:linear algebra Linear algebra performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rdiv! on LU object is much slower than ldiv!
1 participant