Adopt Base's annotated types/functions as API #81
+92
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change has been discussed with other maintainers on Slack (the API shift, but not the exporting), so I'm inclined to merge this soon if I can figure out how to make doctests happy. |
topolarity
approved these changes
Aug 19, 2024
tecosaur
force-pushed
the
api-adoption
branch
2 times, most recently
from
d1d62bc
to
1beedda
Compare
|
This is held up by difficulty figuring out the Documenter side of things. |
|
It's hard to see how I can make this work before JuliaDocs/Documenter.jl#1781 is resolved 😬. Perhaps @mortenpi might have an idea? |
KristofferC
force-pushed
the
api-adoption
branch
from
1beedda
to
769e49a
Compare
tecosaur
force-pushed
the
api-adoption
branch
2 times, most recently
from
59d5e03
to
8264fc8
Compare
This opens the door to shuffling parts currently implemented in Base into this stdlib without breaking any public APIs.
tecosaur
force-pushed
the
api-adoption
branch
from
8264fc8
to
0e3281a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens the door to shuffling parts currently implemented in Base into this stdlib without breaking any public APIs.
To try to help avoid people using
Base.Annot...anyway, I've exported these bindings. I think this is reasonable given unlike inBasethis library needs to be deliberately imported.