Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use oneunit(T) in construct_seeds #659

Open
wants to merge 6 commits into
base: release-0.10
Choose a base branch
from

Conversation

longemen3000
Copy link

replaces #652 , fixes #651

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -3.13% ⚠️

Comparison is base (2ff6808) 89.59% compared to head (a897f71) 86.46%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-0.10     #659      +/-   ##
================================================
- Coverage         89.59%   86.46%   -3.13%     
================================================
  Files                11       10       -1     
  Lines               961      894      -67     
================================================
- Hits                861      773      -88     
- Misses              100      121      +21     
Files Changed Coverage Δ
src/dual.jl 78.67% <100.00%> (-3.66%) ⬇️
src/partials.jl 84.21% <100.00%> (-0.14%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/dual.jl Outdated Show resolved Hide resolved
@longemen3000
Copy link
Author

The error in Julia latest seems unrelated?

@longemen3000
Copy link
Author

bump?

@RomeoV
Copy link

RomeoV commented Nov 10, 2023

Could use a rebase onto master. That makes the errors go away for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants