Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usingibm-licensing-service-instance deployment to ensure the exact namespace #2206

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

qpdpQ
Copy link
Contributor

@qpdpQ qpdpQ commented Sep 18, 2024

What this PR does / why we need it:
Handle the edge case which v3 and v4 licensing operator co-existence in the same cluster.

  • If multiple Licensing operators is found, we use ibm-licensing-service-instance deployment to ensure the exact namespace where licensing v4 is installed.
  • If multiple licensing-service-instance found, error out

Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/64782

@qpdpQ qpdpQ changed the title ibm-licensing-service-instance deployment to ensure the exact namespace usingibm-licensing-service-instance deployment to ensure the exact namespace Sep 18, 2024
Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, qpdpQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 930b87b into IBM:scripts-dev Sep 19, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants