Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] G7 Portal Webview #1027

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[Feat] G7 Portal Webview #1027

wants to merge 12 commits into from

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Aug 16, 2024 •
edited
Loading

Summary

closes https://github.com/HyperPlay-Gaming/product-management/issues/565

Testing

Test case 1

  1. Go to quests page
  2. Click Earn Game7 Credits
  3. See the summon portal webview

Test case 2

  1. Go to quests page
  2. Click View All Quests
  3. See the HyperPlay quests page

Screenshots

image
image

@BrettCleary BrettCleary self-assigned this Aug 16, 2024
@BrettCleary BrettCleary marked this pull request as ready for review September 12, 2024 19:27
@BrettCleary BrettCleary added PR: Ready-For-Review PR is ready to be reviewed by peers and removed PR: WIP labels Sep 12, 2024
@BrettCleary BrettCleary requested review from eliobricenov, jiyuu-jin and flavioislima and removed request for jiyuu-jin September 12, 2024 19:32
flavioislima
flavioislima approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm
Should we not remove the Webview controls to a more seamless integration like we do with our store?

@BrettCleary
Copy link
Collaborator Author

Code lgtm Should we not remove the Webview controls to a more seamless integration like we do with our store?

Yes. This will be removed when I update to the production url for Summon portal

nyghtstalker
nyghtstalker approved these changes Sep 12, 2024
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did my best to break it but everything looks good and seems to be working. Any issues I found were on G7 side and not ours. Great job!

@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@eliobricenov eliobricenov Awaiting requested review from eliobricenov

@jiyuu-jin jiyuu-jin Awaiting requested review from jiyuu-jin

Assignees

@BrettCleary BrettCleary

Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrettCleary @flavioislima @nyghtstalker