Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS update-test name #18295

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix macOS update-test name #18295

merged 2 commits into from
Sep 9, 2024

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Sep 9, 2024 •
edited
Loading

☝️

@dduugg
Copy link
Sponsor Member Author

dduugg commented Sep 9, 2024

hmm, i think someone with elevated access needs to do an update dance of the required checks…

@carlocab
Copy link
Member

carlocab commented Sep 9, 2024

Ping @Homebrew/tsc

@Bo98
Copy link
Member

Bo98 commented Sep 9, 2024

Given we only test one macOS here, maybe just shorten it to (macOS) so we don't need to do this dance every year?

dduugg
dduugg commented Sep 9, 2024
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@dduugg dduugg changed the title Fix test name Fix macOS update-test name Sep 9, 2024
@carlocab carlocab merged commit 62375c1 into master Sep 9, 2024
28 checks passed
@carlocab carlocab deleted the dduugg-patch-1 branch September 9, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dduugg @carlocab @Bo98 @MikeMcQuaid