-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-cmd/extract: trim version to only digits/decimals for class & file names #17537
Conversation
Should brew/Library/Homebrew/formula.rb Lines 513 to 516 in 30e2ae1
|
Good point. I've updated this to have Now, |
17c74ac
to
02d1c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
02d1c7e
to
549b85a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with suggestions applied, thanks @EricFromCanada!
…e names Co-authored-by: Mike McQuaid <[email protected]>
90209bc
to
b8dc576
Compare
Thanks @EricFromCanada! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?When generating a class name for a formula, remove any non-digit characters following the
@
if present. Allows a command likebrew extract --version
to handle versions that don't start with digits. Fixes #16881.