Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor-install: fix incorrect portable Ruby version reference. #17504

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

MikeMcQuaid
Copy link
Member

  • Use the HOMEBREW_PORTABLE_RUBY_VERSION environment variable to determine the version of the Portable Ruby to use in vendor-install.sh and ruby.sh.
  • Replace the docs/.ruby-version file with a symlink to Library/Homebrew/.ruby-version.
  • Fix an incorrect HOMEBREW_LIBRARY comment.
  • Use a simpler HOMEBREW_USING_PORTABLE_RUBY definition.

- Use the `HOMEBREW_PORTABLE_RUBY_VERSION` environment variable to
  determine the version of the Portable Ruby to use in
  `vendor-install.sh` and `ruby.sh`.
- Replace the `docs/.ruby-version` file with a symlink to
 `Library/Homebrew/.ruby-version`.
- Fix an incorrect `HOMEBREW_LIBRARY` comment.
- Use a simpler `HOMEBREW_USING_PORTABLE_RUBY` definition.
Base automatically changed from portable-ruby-cleanup to master June 14, 2024 11:31
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike!

@MikeMcQuaid MikeMcQuaid merged commit 754c026 into master Jun 14, 2024
23 checks passed
@MikeMcQuaid MikeMcQuaid deleted the even_more_portable_ruby_cleanup branch June 14, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants