Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostic: fix cask taps doctor output. #17467

Merged
merged 1 commit into from
Jun 11, 2024
Merged

diagnostic: fix cask taps doctor output. #17467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Library/Homebrew/diagnostic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@

taps = (Tap.to_a + [CoreCaskTap.instance]).uniq

add_info "Homebrew Cask Taps:", taps.filter_map do |tap|
taps_info = taps.filter_map do |tap|

Check warning on line 948 in Library/Homebrew/diagnostic.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/diagnostic.rb#L948 

Added line #L948 was not covered by tests
cask_count = begin
tap.cask_files.count
rescue
Expand All @@ -956,6 +956,7 @@

"#{tap.path} (#{Utils.pluralize("cask", cask_count, include_count: true)})"
end
add_info "Homebrew Cask Taps:", taps_info

Check warning on line 959 in Library/Homebrew/diagnostic.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/diagnostic.rb#L959 

Added line #L959 was not covered by tests

taps_string = Utils.pluralize("tap", error_tap_paths.count)
"Unable to read from cask #{taps_string}: #{error_tap_paths.to_sentence}" if error_tap_paths.present?
Expand Down