Apply suggestions from code review

Homebrew · May 26, 2024 · 7be2632 · 7be2632
1 parent fdb347c
commit 7be2632
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Library/Homebrew/sbom.rb b/Library/Homebrew/sbom.rb
@@ -121,12 +121,12 @@ def self.fetch_schema!
     end
   end
 
-  sig { params(bottling: T::Boolean).returns(T.nilable(T::Boolean)) }
+  sig { params(bottling: T::Boolean).returns(T::Boolean) }
   def valid?(bottling: false)
     unless require? "json_schemer"
       error_message = "Need json_schemer to validate SBOM, run `brew install-bundler-gems --add-groups=bottle`!"
       odie error_message if ENV["HOMEBREW_ENFORCE_SBOM"]
-      return nil
+      return true
     end
 
     schema = SBOM.fetch_schema!
@@ -156,7 +156,7 @@ def write(validate: true, bottling: false)
     # will no longer be valid.
     Formula.clear_cache unless spdxfile.exist?
 
-    if validate && (valid = valid?(bottling:)).present? && !valid
+    if validate && !valid?(bottling:)
       opoo "SBOM is not valid, not writing to disk!"
       return
     end