Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions/sync/shared-config: fix vendor exclude. #175

Merged
merged 1 commit into from
Aug 23, 2024
Merged

actions/sync/shared-config: fix vendor exclude. #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/sync/shared-config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ def git(*args)
homebrew_repository_path/"Library/#{rubocop_yaml}",
permitted_classes: [Symbol, Regexp],
)
homebrew_rubocop_config_yaml["AllCops"]["Exclude"] << '"vendor/**/*"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The synced files don't look right (see e.g., Homebrew/rubydoc.brew.sh#651), should this instead be:

Suggested change
homebrew_rubocop_config_yaml["AllCops"]["Exclude"] << '"vendor/**/*"'
homebrew_rubocop_config_yaml["AllCops"]["Exclude"] << "vendor/**/*"

homebrew_rubocop_config = homebrew_rubocop_config_yaml.reject do |key, _|
key.match?(%r{\Arequire|inherit_from|inherit_mode|Cask/|Formula|Homebrew|Performance/|RSpec|Sorbet/})
end.to_yaml
homebrew_docs_rubocop_config_yaml = YAML.load_file(
homebrew_repository_path/"docs/#{rubocop_yaml}",
permitted_classes: [Symbol, Regexp],
)
homebrew_docs_rubocop_config_yaml["AllCops"]["Exclude"] << '"vendor/**/*"'
homebrew_docs_rubocop_config = homebrew_docs_rubocop_config_yaml.reject do |key, _|
key.match?(%r{\AFormulaAudit/|Sorbet/})
end.to_yaml
Expand Down