Skip to content

Commit

Permalink
actions/sync/shared-config: don't run bundle for custom rubies.
Browse files Browse the repository at this point in the history
Ensure that we're only going to do this in cases where we actually
know that we have the correct Ruby version.
  • Loading branch information
MikeMcQuaid committed Jun 11, 2024
1 parent 4d6ec3f commit 423b103
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/actions/sync/shared-config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def git(*args)

custom_ruby_version_repos = %w[
mass-bottling-tracker-private
ruby-macho
].freeze
custom_rubocop_repos = %w[
ci-orchestrator
Expand Down Expand Up @@ -174,7 +175,7 @@ def git(*args)
end

# Update Gemfile.lock if it exists, based on the Ruby version.
if (target_directory_path/"Gemfile.lock").exist?
if !custom_ruby_version_repos.include?(repository_name) && (target_directory_path/"Gemfile.lock").exist?

Check failure on line 178 in .github/actions/sync/shared-config.rb

View workflow job for this annotation

GitHub Actions / sync (Homebrew/.github)

Homebrew/NegateInclude: Use `.exclude?` and remove the negation part.
Dir.chdir target_directory_path do
puts "Running bundle install..."
system "bundle update --ruby --bundler --quiet >/dev/null"
Expand Down

0 comments on commit 423b103

Please sign in to comment.