Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

BuildList: Fix downloading builds with new download url [Do not merge] #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SirMangler
Copy link

This PR revives the DolphinBisectTool by utilising the URLs that will be supplied in the buildlist if this open pull request to add download URLs with the revisions in the build list is merged.

This cannot be fully tested unless that PR is merged. However the testing that I could do suggests this works. I have opened this pull request in preparation and so that any reviews may be made. This may be followed with another commit to fix or adjust any behaviour if needed.

@Helios747
Copy link
Owner

hi, thanks for taking a look at this. I'll look at this later tonight or tomorrow and if it works, I'll merge it. But I'm not really involved in Dolphin anymore and this is mostly unmaintained. If you wish to take it up, feel free to fork and make a post on the Dolphin forums

@SirMangler
Copy link
Author

hi, thanks for taking a look at this. I'll look at this later tonight or tomorrow and if it works, I'll merge it. But I'm not really involved in Dolphin anymore and this is mostly unmaintained. If you wish to take it up, feel free to fork and make a post on the Dolphin forums

I appreciate the honesty. I assumed you weren't actively maintaining this repository any more, my hope is having both of these PRs merged would mean that the Dolphin Window's community suddenly have a working bisect tool again, which they have been lacking for too long even if the intention is they eventually migrate to a new tool at a later date.

@Helios747
Copy link
Owner

Looked through this, looks good (and you did a bit of cleanup of my questionably maintainable code, thank you)

But yeah, can't really test this until the PR against dolphin-emu/www gets merged. I'll rejoin IRC and poke around to see who's maintaining the site now, maybe it's still Delroth

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants