fix UnusedID returning wrong ID

HPInc · Jul 9, 2021 · 15713ab · 15713ab
1 parent e1d9c5d
commit 15713ab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/core.go b/core.go
@@ -153,6 +153,7 @@ func (rs *Resources) UnusedID() uint32 {
 	for i, id := range ids {
 		if id != i {
 			lowest = i
+			break
 		}
 	}
 	if lowest == 0 {

diff --git a/core_test.go b/core_test.go
@@ -193,7 +193,9 @@ func TestResources_UnusedID(t *testing.T) {
 		{"one-object", &Resources{Objects: []*Object{{ID: 2}}}, 1},
 		{"two", &Resources{Assets: []Asset{&BaseMaterials{ID: 1}}}, 2},
 		{"sequence", &Resources{Assets: []Asset{&BaseMaterials{ID: 1}}, Objects: []*Object{{ID: 2}}}, 3},
-		{"sparce", &Resources{Assets: []Asset{&BaseMaterials{ID: 1}}, Objects: []*Object{{ID: 3}}}, 2},
+		{"sparce", &Resources{Assets: []Asset{&BaseMaterials{ID: 12}}, Objects: []*Object{
+			{ID: 6}, {ID: 4}, {ID: 8}, {ID: 10}, {ID: 2}}}, 1,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {