[Issue #1809] Add load-transform SFN #2004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplybeah
approved these changes
May 14, 2024
jamesbursa
reviewed
May 14, 2024
Comment on lines
+16
to
+17
| "poetry", | ||
| "run", |
There was a problem hiding this comment.
I think running poetry in production isn't needed and adds additional complexity.
It's a development & build tool and the docker image has clean dependencies and is an isolated environment by running in a container.
When testing, I was using this command line:
["flask", "--app=src.app:create_app", "data-migration", "load-transform"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1809
Time to review: 2 mins
Changes proposed
Activates the load-transform job in every environment. In dev it runs with
--no-*on everything, so it runs but doesn't do anything.