Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ CANs List #2804

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

feat: ✨ CANs List #2804

wants to merge 47 commits into from

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Sep 16, 2024 •
edited
Loading

What changed

  • adds the CANs list and friends
    • CANTable and CANTableRow
  • adds pagination
  • adds tooltips
  • adds type definition files

Issue

#346 #2137

How to test

  1. navigate to /cans
  2. see cans list
  3. 💰 profit

Screenshots

Screen.Recording.2024-09-19.at.3.30.42.PM.mov

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr self-assigned this Sep 16, 2024
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Sep 16, 2024
@fpigeonjr fpigeonjr changed the title wip: CANs List FE round 1 feat: ✨ CANs List Sep 18, 2024
@fpigeonjr fpigeonjr marked this pull request as ready for review September 20, 2024 16:46
fpigeonjr
fpigeonjr commented Sep 20, 2024
View reviewed changes
frontend/cypress/fixtures/initial-state.json
@@ -1,15 +1,4 @@
{
"canList": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johndeange not sure what this does but removing it fixes the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndeange johndeange Awaiting requested review from johndeange

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

@devops-chris devops-chris Awaiting requested review from devops-chris

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

At least 2 approving reviews are required to merge this pull request.

Assignees

@fpigeonjr fpigeonjr

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fpigeonjr