Add POST and PATCH /cans/ endpoints #2783
Closed
+427
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajohnson90
added
task
…ng service layer for controller to call. Updating test to include more of /cans/ POST endpoint. Added two new auth client config fixtures.
jonnalley
removed
the
Dev Backend Ready
…it tests. Functionality not complete because we are now using a service layer to isolate business logic. updated openapi doc to match new endpoint.
rajohnson90
changed the title
rajohnson90
requested review from
johndeange,
fpigeonjr,
maiyerlee and
Santi-3rd
…d test_service_patch_can to not rely on hard-coded id for table item.
|
I ended up finishing all the work before this could be merged in. The second PR was a branch off this branch and should include EVERYTHING in the merge to main. Closing this PR to clean up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Adding the following /cans/ endpoints:
POST /cans/ (create a new CAN)
PATCH /cans/{id} (Update a can, replacing only the changed fields
I added a new service layer for CANs so that we can isolate the business logic away from the API logic. New unit tests were written with mockers in order to isolate and test these layers individually. Additionally, I added OpsEvents for the creation and update of CANs. Finally, I added the obligate_by field to the CAN schema because that information is missing and is needed by the front end.
Issue
#2781
#2754
How to test
Run python unit tests
Definition of Done Checklist