Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting to My Alerts #378

Merged
merged 38 commits into from
Mar 13, 2021
Merged

Add sorting to My Alerts #378

merged 38 commits into from
Mar 13, 2021

Conversation

kryswisnaskas
Copy link
Collaborator

@kryswisnaskas kryswisnaskas commented Mar 12, 2021

187

Description of change
Adds sorting to "My Alerts"

How to test

  • pull changes
  • verify that my alerts can be sorted

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

373

Description of change
Add sortable indicators to activity report columns

How to test
pull down changes. Check activity reports list.

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

370

Description of change
The current version of the node aws sdk does not provide the presigned url call with the region, so it defaults to us-east-1 unless you specify a region in the s3 config.

This PR adds a region to the config when running in cloud.gov.

How to test
Go to the sandbox, and upload a file. Then go to the review screen and try to download it.

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

360

Description of change

The API call to populate the main reports table is now filtered to return only approved reports.

How to test

  1. Pull down
  2. Create a draft report
  3. Login with another user with read permissions to the region of the report from step 2
  4. Note the draft report does not show up in the list of reports
  5. Submit and approve the report from step 2
  6. Login with the user from step 3, the report shows up in the list of reports as Approved

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

377

Description of change

  • Import all grants and grantees, rather than just those we've seen before or are currently Active

How to test

  • Unit tests have been updated

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

@rahearn rahearn merged commit 8904b0d into HHS:main Mar 13, 2021
PatricePascual-ACF pushed a commit that referenced this pull request Aug 6, 2021
* upgrade react-scripts

* add browserslist, glob-parent, tar

Co-authored-by: Sarah-Jaine Szekeresh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants